Update glTF add-on imports to support Blender 4.3 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
force-pushed
the
support-blender-4.3
branch
3 times, most recently
from
4f1ff3e to
85d9a15
Compare
Exairnous
force-pushed
the
support-blender-4.3
branch
from
85d9a15 to
87eebcb
Compare
A lot of the files in the glTF add-on were renamed to be shorter to better accommodate the path length limit in Windows for the Blender 4.3 release (KhronosGroup/glTF-Blender-IO#2331). This prevents the Hubs add-on from loading at all because many of the previous imports are no longer valid. This commit fixes the imports and restructures the glTF add-on imports so that imports common to all versions are done first, then each Blender version has a section for the rest of it's imports from the glTF add-on. This results in some duplication of imports, but keeps things clear and simple. Cleanup: * Several imports from the same file have been combined into a single import. * Imports at the beginning of the file have been ordered alphabetically (mostly). * Imports at the beginning of the file with the format `from x import y` have been placed after imports with the format `import x`. * One of the`BLACK_LIST` imports has been moved to the top of its function to be more readable with its increase in complexity. * Added a comment to describe why `BLACK_LIST` is imported in a function instead of at the beginning of the file.
Exairnous
force-pushed
the
support-blender-4.3
branch
from
87eebcb to
2ad936a
Compare
|
I'm merging this since there have been no objections and @Spiderguy-F gave his approval in Discord (https://discord.com/channels/498741086295031808/964183314674098276/1320375581698949121). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the files in the glTF add-on were renamed to be shorter to better accommodate the path length limit in Windows for the Blender 4.3 release (KhronosGroup/glTF-Blender-IO#2331). This prevents the Hubs add-on from loading at all because many of the previous imports are no longer valid.
This PR fixes the imports and restructures the glTF add-on imports so that imports common to all versions are done first, then each Blender version has a section for the rest of it's imports from the glTF add-on. This results in some duplication of imports, but keeps things clear and simple.
Cleanup:
from x import yhave been placed after imports with the formatimport x.BLACK_LISTimports has been moved to the top of its function to be more readable with its increase in complexity.BLACK_LISTis imported in a function instead of at the beginning of the file.